Prs/add create cluster module #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brueggemann
force-pushed
the
prs/add-create-cluster-module
branch
5 times, most recently
from
b189ed1 to
02ed21d
Compare
|
This PR is blocked by #36 because we need to create the ConfigMap before we can create the CephCluster resource |
brueggemann
force-pushed
the
prs/add-create-cluster-module
branch
4 times, most recently
from
020cdee to
b0d28f8
Compare
Signed-off-by: Jan-Marten Brüggemann <[email protected]>
brueggemann
force-pushed
the
prs/add-create-cluster-module
branch
from
b0d28f8 to
ff96f11
Compare
|
This is also blocked by #37 |
Signed-off-by: Tobias Wolf <[email protected]>
Signed-off-by: Tobias Wolf <[email protected]>
Signed-off-by: Jan-Marten Brüggemann <[email protected]>
Signed-off-by: Tobias Wolf <[email protected]>
NotTheEvilOne
force-pushed
the
prs/add-create-cluster-module
branch
from
06d5ce9 to
a110d66
Compare
Signed-off-by: Tobias Wolf <[email protected]>
NotTheEvilOne
force-pushed
the
prs/add-create-cluster-module
branch
from
e94a40e to
0dcf376
Compare
|
In general there is almost no logging in the module, should we add that maybe? @NotTheEvilOne |
boekhorstb1
reviewed
Jun 10, 2024
Signed-off-by: Tobias Wolf <[email protected]>
Signed-off-by: Tobias Wolf <[email protected]>
boekhorstb1
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #31